Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aarch64 architecture (which is equivalent to arm64) #63

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

h-matsuo
Copy link
Contributor

@h-matsuo h-matsuo commented Oct 30, 2024

Overview

This PR adds support for aarch64 by updating the case handling to treat aarch64 as equivalent to arm64.

Details

In certain OS environments, such as Amazon Linux 2023, uname -m returns aarch64 instead of arm64, even though both represent the same 64-bit ARM architecture.

For instance, when using this action on self-hosted runners configured with AWS CodeBuild and Amazon Linux 2023, an Unsupported architecture error occurs because the current script expects uname -m to return arm64.

I’ve already verified that this patch works as expected in the environment described above.

@h-matsuo h-matsuo changed the title Support for aarch64 architecture (which is equivalent to arm64) Support for aarch64 architecture (which is equivalent to arm64) Oct 31, 2024
@shmokmt shmokmt self-requested a review November 19, 2024 13:47
Copy link
Member

@shmokmt shmokmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@shmokmt shmokmt merged commit 9b2b39f into reviewdog:main Nov 21, 2024
16 checks passed
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.12.2 Changes:v1.12.1...v1.12.2

@h-matsuo h-matsuo deleted the patch-1 branch November 21, 2024 10:19
@shmokmt
Copy link
Member

shmokmt commented Nov 21, 2024

@h-matsuo
Released 🚀
https://github.com/reviewdog/action-trivy/releases/tag/v1.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants