Fix severity conversion; calculate overall severity based on RuboCop fail level #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop's severity levels are represented by RuboCop::Cop::Severity obejcts, not symbols. Internally, this objects holds a symbol in its `name` attribute an implements comparison methods. Sadly, these comparisons aren't reversable: `severity === :info => true`, but `:info === severity => false`. The ruby case statement performs tripple-equals comparisons with the argument to the `when` clause as the first operand, so the existing case statement always returned `UNKNOWN_SEVERITY`.
mgrachev
approved these changes
Jun 2, 2023
|
@reidab Thank for your contribution 👍 Before merging, please fix CI builds in your PR 🙏 |
|
Okay, that should be cleaned up now. |
|
🚀 [bumpr] Bumped! New version:v2.3.3 Changes:v2.3.2...v2.3.3 |
|
Hi, @reidab! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop's severity levels are represented by
RuboCop::Cop::Severityobjects, not symbols. Internally, this objects holds a symbol in itsnameattribute an implements comparison methods.Sadly, these comparisons aren't reversable:
severity === :info => true, but:info === severity => false.The ruby case statement performs tripple-equals comparisons with the argument to the
whenclause as the first operand, so the existing case statement always returnedUNKNOWN_SEVERITY.In addition to fixing the above issue, this PR adds mappings for the non-standard RuboCop
conventionandrefactorseverity levels toINFOand calculates a top-levelseverityvalue in the rdjson output based on RuboCop's configured fail level.Fixes #75