Change original_output in RdjsonFormatter, adding file
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `original_output`, adding file. The field is printed by reviewdog on running the action with github-pr-review reporter. Before, it did not contain file, thus messages were not fully informative. E.g. ``` C: 30: 54: Rails/AttributeDefaultBlockValue: Pass method in a block to `:default` option. ``` This change fixes the field, adding file: ``` app/models/user.rb:30:54: C: Rails/AttributeDefaultBlockValue: Pass method in a block to `:default` option. ```
|
@Slike9 Thank you 👍 |
|
🚀 [bumpr] Bumped! New version:v2.3.2 Changes:v2.3.1...v2.3.2 |
|
Hi, @Slike9! We merged your PR to reviewdog! 🐶 We just invited you to join the @reviewdog organization on GitHub. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original_outputfield inRdjsonFormatteris printed by reviewdog on running the action with github-pr-review reporter.Before, it did not contain file, thus messages were not fully informative.
Example https://github.com/Slike9/GitHub-Actions-PlayGround/actions/runs/3887880250/jobs/6634622915#step:5:61
This PR fixes the field, adding file.
Example https://github.com/Slike9/GitHub-Actions-PlayGround/actions/runs/3887873154/jobs/6634608438#step:5:61
This format is borrowed from ClangStyleFormatter formatter (default formatter,
ProgressFormatter, inherits it).