Fail fast when an error happens in script.sh #36
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion that is related to #34.
As like the problem reported in #34, when gem installation or rubocop command or any command in the shell script fails, I think also the script should fail immediately and tell the failure through an exit status.
On my end, although the problem described in #34 had been happening in a certain term our team wasn't able to find it keep failing due to the status kept green check mark.
References
ref https://stackoverflow.com/questions/19622198/what-does-set-e-mean-in-a-bash-script