Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fast when an error happens in script.sh #36

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

ohbarye
Copy link
Member

@ohbarye ohbarye commented Mar 5, 2021

This is a suggestion that is related to #34.

As like the problem reported in #34, when gem installation or rubocop command or any command in the shell script fails, I think also the script should fail immediately and tell the failure through an exit status.

On my end, although the problem described in #34 had been happening in a certain term our team wasn't able to find it keep failing due to the status kept green check mark.

image

References

ref https://stackoverflow.com/questions/19622198/what-does-set-e-mean-in-a-bash-script

@mgrachev mgrachev merged commit 98a83df into reviewdog:master Mar 5, 2021
@mgrachev
Copy link
Member

mgrachev commented Mar 5, 2021

@ohbarye 👋 Thank you for your contribution! 🚀

@review-dog
Copy link
Member

Hi, @ohbarye! We merged your PR to reviewdog! 🐶
Thank you for your contribution! ✨

We just invited you to join the @reviewdog organization on GitHub.
Accept the invite by visiting https://github.com/orgs/reviewdog/invitation.
By joining the team, you'll be a part of reviewdog community and can help the maintainance of reviewdog.

Thanks again!

@ohbarye ohbarye deleted the patch-1 branch March 5, 2021 10:39
@ohbarye
Copy link
Member Author

ohbarye commented Mar 5, 2021

Thanks for your review and inviting me to the organization! (it's completely automated? 😄 )

@mgrachev
Copy link
Member

mgrachev commented Mar 5, 2021

it's completely automated? 😄

Yes 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants