-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[빌드5] 리뷰 목록 위젯 모든 기능 동작 완료 #48
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(related to: #34)
(related to: #46) 기존에는 임시로 리뷰 100개, 키워드 100개를 기준으로 max 값을 잡았음, -> 리뷰와 키워드 수가 100이 넘어가는 경우는 나타낼 수 없음 따라서 상대적으로 전체 리뷰의 개수, 각 키워드의 개수로 max 값을 변경
(related to: #34)
feat: 리뷰 및 태그 통계 api 연결, 리뷰 페이징 추가 (related to: #34)
feat: 부모에게 메세지 전송하는 hook 추가, 리뷰 작성 완료시 사용 (#25)
1. 기존 max값 -> 각각 키워드의 긍정과 부정 개수를 더한 값을 max로 했더니, 같은 숫자여도 키워드에 따라 그래프가 다름 => 각 키워드의 긍정과 부정 개수들 중 가장 큰 값을 max로 설정하여 모든 키워드의 max가 일관되도록 변경 (max값 계산은 useMemo를 사용하여 중복 계산 방지) 2. 총 0개의 리뷰 중에서 .. 부분에 값 연결
-> 태그 불러와서 view까지, 아직 클릭시 응답 없음
feat: 태그 api 연결, 태그에 따른 필터링 기능 추가 (related to: #34)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
#34 #35
작업 사항