Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: only create apps that are needed by a developer #553

Merged
merged 15 commits into from
May 6, 2024
Merged

feat: only create apps that are needed by a developer #553

merged 15 commits into from
May 6, 2024

Conversation

Nabhag8848
Copy link
Member

@Nabhag8848 Nabhag8848 commented May 1, 2024 •
edited
Loading

Description

  • Allow Revert Developers to Create Revert App.
  • In Modal, Heading and Button remains fixed in case of overflow of Integration conversion to scroll.
    Closes [ISSUE-REVERT]: Only create apps that are needed by a developer #496
  • Fixes Env Selector rerendering issue on change of Env.
  • UI to use Grid CSS to fix Grid view for Created Apps.
  • Used float units (rem) and removed maximum hard coded px to rem values, for layout changed to use viewport units.

Type of change

Closes #496
/claim #496

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshot / Video

Screen.Recording.2024-05-06.at.12.16.38.mov

@vercel Vercel
Copy link

vercel bot commented May 1, 2024

@Nabhag8848 is attempting to deploy a commit to the OpenInt Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2024 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@Nabhag8848 Nabhag8848 changed the title [ Fix ] Create apps that are needed by a developer feat: Create apps that are needed by a developer May 2, 2024
@Nabhag8848 Nabhag8848 marked this pull request as ready for review May 6, 2024 07:01
@jatinsandilya jatinsandilya changed the title feat: Create apps that are needed by a developer feat: only create apps that are needed by a developer May 6, 2024
@jatinsandilya jatinsandilya self-requested a review May 6, 2024 07:58
@algora-pbc algora-pbc bot mentioned this pull request May 6, 2024
Closed
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented May 6, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

jatinsandilya
jatinsandilya requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor copy changes are present @Nabhag8848 otherwise its great to merge! 🎉

packages/client/src/features/integration/AddIntegration.tsx Outdated Show resolved Hide resolved
packages/client/src/features/integration/AddIntegration.tsx Outdated Show resolved Hide resolved
packages/client/src/features/integration/AddIntegration.tsx Outdated Show resolved Hide resolved
packages/client/src/home/integrations.tsx Outdated Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 9:33am

@Nabhag8848 Nabhag8848 requested a review from jatinsandilya May 6, 2024 09:27
jatinsandilya
jatinsandilya approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧨 🖖🏼

@jatinsandilya jatinsandilya merged commit 3d33240 into revertinc:main May 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatinsandilya jatinsandilya jatinsandilya approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE-REVERT]: Only create apps that are needed by a developer
2 participants
@Nabhag8848 @jatinsandilya