Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remaining Support Pagination in CRM search API endpoints #550

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

manish-singh-bisht
Copy link
Contributor

@manish-singh-bisht manish-singh-bisht commented Apr 25, 2024

Description

fixes #546

Adds pagination support for Zoho CRM, Close crm, ms dynamics 365 sales, pipedrive.
Pagination has been added to the endpoints that have search api in the above mentioned crms.

Remaining: Salesforce (a discussion is required on how to proceed towards pagination in this integration). (Edit: pagination will be handled by the users themselves for the salesforce crm).

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

via postman

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Apr 25, 2024

@manish-singh-bisht is attempting to deploy a commit to the OpenInt Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Apr 25, 2024

Thank you for following the naming conventions for pull request titles! 🙏

@manish-singh-bisht manish-singh-bisht marked this pull request as draft April 25, 2024 08:42
@manish-singh-bisht manish-singh-bisht marked this pull request as ready for review April 27, 2024 15:19
Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 5:04pm

@jatinsandilya jatinsandilya merged commit 38556e1 into revertinc:main Apr 29, 2024
7 of 8 checks passed
@manish-singh-bisht
Copy link
Contributor Author

/claim #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE-REVERT]: Support Pagination in CRM search API endpoints
2 participants