Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oauth flow via customer apps #102

Merged
merged 9 commits into from
Jun 29, 2023

Conversation

hvinder
Copy link
Collaborator

@hvinder hvinder commented Jun 27, 2023

fixes #90, #91

@railway-app
Copy link

railway-app bot commented Jun 27, 2023

This PR was not deployed automatically as @hvinder does not have access to the Railway project.

In order to get automatic PR deploys, please add @hvinder to the project inside the project settings page.

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
revert-client ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 5:57am
revert-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 29, 2023 5:57am

@jatinsandilya jatinsandilya changed the title feat:granular permissions for crm apps feat: oauth flow via customer apps Jun 28, 2023
packages/backend/prisma/schema.prisma Outdated Show resolved Hide resolved
packages/backend/routes/v1/metadata.ts Show resolved Hide resolved
@hvinder hvinder requested a review from jatinsandilya June 29, 2023 06:09
@jatinsandilya jatinsandilya changed the base branch from main to staging June 29, 2023 06:31
Copy link
Contributor

@jatinsandilya jatinsandilya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@jatinsandilya jatinsandilya merged commit 2ddd056 into staging Jun 29, 2023
@@ -29,11 +29,7 @@ class ConnectionService {
const { 'x-revert-api-token': token } = req.headers;
const connections: any = await prisma.connections.findMany({
where: {
account: {
is: {
Copy link
Contributor

@jatinsandilya jatinsandilya Jun 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hvinder This is a bug. We'd need to use the private token here instead for comparison instead of the public token.

jatinsandilya pushed a commit that referenced this pull request Jun 30, 2023
* add scope to connections and api to fetch scopes

* Use db scopes for oauth

* Use db scopes for sdk functions

* Add scopes to metadata api

* Use client app id, if available

* Create apps table

* revert revert-dev

* revert revert-dev

* Create default app for all accounts
jatinsandilya pushed a commit that referenced this pull request Jun 30, 2023
* add scope to connections and api to fetch scopes

* Use db scopes for oauth

* Use db scopes for sdk functions

* Add scopes to metadata api

* Use client app id, if available

* Create apps table

* revert revert-dev

* revert revert-dev

* Create default app for all accounts
jatinsandilya pushed a commit that referenced this pull request Jul 6, 2023
* add scope to connections and api to fetch scopes

* Use db scopes for oauth

* Use db scopes for sdk functions

* Add scopes to metadata api

* Use client app id, if available

* Create apps table

* revert revert-dev

* revert revert-dev

* Create default app for all accounts
jatinsandilya pushed a commit that referenced this pull request Jul 11, 2023
* feat: oauth flow via customer apps (#102)

* add scope to connections and api to fetch scopes

* Use db scopes for oauth

* Use db scopes for sdk functions

* Add scopes to metadata api

* Use client app id, if available

* Create apps table

* revert revert-dev

* revert revert-dev

* Create default app for all accounts

* hotfix (#112)

* chore: capture remaining exceptions

* Toggle to switch revert app

* Fix

* Change subtext font size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Customer CRM Apps to be used in the OAuth flow
2 participants