feat: add contexts to interfaces #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 83.38% 83.12% -0.27%
==========================================
Files 7 7
Lines 620 634 +14
==========================================
+ Hits 517 527 +10
- Misses 71 78 +7
+ Partials 32 29 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I've added tests, and think this is mostly ready to go, modulo any changes that you think are good. |
reugn
reviewed
Dec 22, 2022
| } | ||
|
|
||
| func (sched *StdScheduler) startExecutionLoop() { | ||
| func (sched *StdScheduler) startExecutionLoop(ctx context.Context) { | ||
|
|
quartz/scheduler_test.go
Outdated
| } | ||
| } | ||
| for _, tt := range []string{"context", "stop"} { | ||
| if tt == "stop" { |
There was a problem hiding this comment.
Requires time.Sleep in both cases. Otherwise, it fails locally.
There was a problem hiding this comment.
interesting. It passes locally for me, but my machine is linux and kind of a beast, but I took out if statement.
Co-authored-by: Eugene R. <[email protected]>
reugn
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still want to do some work to add test coverage of this, and potentially exercise the new signal channel, but I'm pretty confident in the general approach, and wanted to get some early feedback.
Addresses: #40