Fixed category on the remote repository to be an attribute instead of…

… a new tag
retroluxfilm · Feb 19, 2022 · 17e97c6 · 17e97c6
1 parent 1b2e801
commit 17e97c6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/Package/Package.php b/src/Package/Package.php
@@ -141,9 +141,10 @@ public function createRemotePackageDescriptor(): RemotePackageDescriptor
         // set category if defined
         $category = $this->packageXML->getCategory();
         if(!empty($category)){
-            $remote->appendChild($xml->createElement(RemotePackageDescriptor::TAG_CATEGORY, $category));
+            $remote->setAttribute(RemotePackageDescriptor::ATTRIBUTE_CATEGORY, $category);
         }
 
+
         $xml->appendChild($remote);
 
         return new RemotePackageDescriptor($remote);

diff --git a/src/Repository/RemotePackageDescriptor.php b/src/Repository/RemotePackageDescriptor.php
@@ -37,8 +37,7 @@ class RemotePackageDescriptor
         TAG_REMOTE = "remote",
         TAG_PICTURE = "picture",
         TAG_DESCRIPTION = "description",
-        TAG_URL = "url",
-        TAG_CATEGORY = "category";
+        TAG_URL = "url";
     /**
      * Attributes of the remote package descriptor
      */
@@ -47,7 +46,8 @@ class RemotePackageDescriptor
         ATTRIBUTE_FILE = "file",
         ATTRIBUTE_BYTES = "bytes",
         ATTRIBUTE_MD5 = "md5sum",
-        ATTRIBUTE_CHECKSUM = "checksum";
+        ATTRIBUTE_CHECKSUM = "checksum",
+        ATTRIBUTE_CATEGORY = "category";
 
     /**
      * remote xml element to fetch data from