Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes #67

Merged
merged 5 commits into from
Mar 5, 2019
Merged

Multiple fixes #67

merged 5 commits into from
Mar 5, 2019

Conversation

ssbarnea
Copy link
Contributor

@ssbarnea ssbarnea commented Mar 4, 2019 •
edited
Loading

Multiple fixes needed in order to fully be able to run tox.

Fixes: https://github.com/metacloud/gilt/issues/66

ssbarnea added 5 commits March 4, 2019 18:03
@ssbarnea
Fix ambigous variable usage
e948e2b 
Use of "l" caused linting failure.
@ssbarnea
Fixed deprecation of getfuncargvalue
783eff4 
getfuncargvalue was deprecated in favour of getfixturevalue
@ssbarnea
Remove use of deprecated pytest.config
7a89fc5 
Use standard pytest marks for slow tests instead.
@ssbarnea
Fixed test failure with GILT_CACHE_DIRECTORY
76006b5 
Tests where failing when GILT_CACHE_DIRECTORY was not ending in '.gilt'.
@ssbarnea
Fix tox failure due to use of relative path with --cov
69fa141 
Move py.test params to setup.cfg in order to make them available
to all pytest executions, regardless if they are run inside or ourside
tox.

This fixes problem where tox was failing to create coverage because
{toxinidir} was expanded to a relative path which is not supported
by pytest-cov.

By using the path mentioned in setup.cfg we avoid this issue as
in this case pytest-cov is able to generate the files.
@ssbarnea ssbarnea force-pushed the master branch 2 times, most recently from 4aebed3 to 0c9180d Compare March 4, 2019 19:06
@retr0h
Copy link
Owner

retr0h commented Mar 4, 2019

Hi @ssbarnea please resubmit without the travis changes. We don't use travis, and don't have any plans to use it in the future. Unfortunately, we don't want to allow travis access to our github org.

@ssbarnea
Copy link
Contributor Author

ssbarnea commented Mar 5, 2019

@retr0h Sure. I will keep travis on my fork in order to validate the changes. I am bit perplexed about how you evaluate any PR with a CI running on them but I will take all measures needed to make these small fixed ship.

The travis is a bit inconvenient but as a note, having a travis file does not mean you need to enable it. It could still prove very useful for anyone forking gilt.

@retr0h
Copy link
Owner

retr0h commented Mar 5, 2019

The travis is a bit inconvenient but as a note, having a travis file does not mean you need to enable it. It could still prove very useful for anyone forking gilt.

That's a good point. I hadn't thought of that. Once this lands, I'd be open to your travis change. Thanks !

@retr0h
Copy link
Owner

retr0h commented Mar 5, 2019 •
edited
Loading 

  py36-unit: commands succeeded
  py27-lint: commands succeeded
  py36-lint: commands succeeded
  doc: commands succeeded
  congratulations :)```

@retr0h retr0h merged commit 234eec2 into retr0h:master Mar 5, 2019
@retr0h
Copy link
Owner

retr0h commented Mar 5, 2019

Thanks @ssbarnea 🎸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retr0h retr0h retr0h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tox unit tests are broken when GILT_CACHE_DIRECTORY is defined
2 participants
@ssbarnea @retr0h