Determine branch in a smarter way #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git module is determine if a version is a branch by regrex check if it's a sha, that makes it confuse on tag vs branch. This commit determines branch by check return code of `git show-ref --verify --quiet refs/heads/<version>`, this will always work because gilt always fetch and checkout, there must have heads ref to a branch.
retr0h
approved these changes
Mar 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git module is determine if a version is a branch by regrex
check if it's a sha, that makes it confuse on tag vs branch.
This commit determines branch by check return code of
git show-ref --verify --quiet refs/heads/<version>, this willalways work because gilt always fetch and checkout, there must
have heads ref to a branch.