Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolves #290 remove util._extend in favor of Object assign #295

Merged
merged 1 commit into from
Apr 28, 2016
Merged

Resolves #290 remove util._extend in favor of Object assign #295

merged 1 commit into from
Apr 28, 2016

Conversation

thoreinstein
Copy link

No description provided.

@deontologician deontologician added this to the Release 1.0 polish milestone Apr 28, 2016
@deontologician
Copy link
Contributor

Cli code looks good to me. This is pretty straightforward @Tryneus any opinions?

@Tryneus
Copy link
Member

Tryneus commented Apr 28, 2016

Looks good to me, a lot cleaner. Thanks, @janders223!

@Tryneus Tryneus merged commit 53e2ee7 into rethinkdb:next Apr 28, 2016
@thoreinstein thoreinstein deleted the no-extends branch April 28, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: ready for review server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thoreinstein @deontologician @Tryneus