Add IO_REPARSE_TAG_PROJFS and IO_REPARSE_TAG_PROJFS_TOMBSTONE #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/c8e77b37-3909-4fe6-a4ea-2b9d423b1ee4, it appears that these 2 were renamed from IO_REPARSE_TAG_GVFS and IO_REPARSE_TAG_GVFS_TOMBSTONE.
MaulingMonkey
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
The old IO_REPARSE_TAG_GVFS and IO_REPARSE_TAG_GVFS_TOMBSTONE identifiers these duplicate are no longer found in winnt.h. Sadly it looks like #[deprecate]ing the old identifiers would require rustc 1.9 which would increase winapi's MSRV. Keeping them seems fine to me though.
LGTM! 👍
- Organization of code
- All definitions go into the source file that directly maps to the header the definition is from.
C:\Program Files (x86)\Windows Kits\10\Include\10.0.18362.0\um\winnt.h
- Definitions are defined in the same order as they are in the original header.
- All definitions go into the source file that directly maps to the header the definition is from.
- Constants
- Names are correct
- Values are correct
- Types are correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/c8e77b37-3909-4fe6-a4ea-2b9d423b1ee4, it appears that these 2 were renamed from IO_REPARSE_TAG_GVFS and IO_REPARSE_TAG_GVFS_TOMBSTONE.