Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IShellFolder and IShellFolder2 #824

Closed
wants to merge 1 commit into from
Closed

Add IShellFolder and IShellFolder2 #824

wants to merge 1 commit into from

Conversation

ArturKovacs
Copy link
Contributor

This PR adds um::shobjidl_core::{IEnumIDList, IShellFolder, IShellFolder2, IEnumExtraSearch} and types and constants related to them.

@ArturKovacs
Add um::shobjidl_core::{IEnumIDList, IShellFolder, IShellFolder2, IEn…
3bac586 
…umExtraSearch} and related types and constants.
@ArturKovacs ArturKovacs changed the title Add IShellFolder, IShellFolder2 Add IShellFolder and IShellFolder2 Oct 27, 2019
@retep998 retep998 added the waiting on review Waiting for a reviewer to review the PR label Oct 28, 2019
@ArturKovacs
Copy link
Contributor Author

If I'm not mistaken, the nightly failing is unrelated to the changes in this PR. However the 1.6.0 channel failing is absolutely related and unfortunatley STRRET cannot be supported without a way to specify a packing of 8.

The first release of Rust that supports this feature is 1.33.0 (see https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1330-2019-02-28). Can we increase the minimal required version for this crate? (Please don't get angry at me 🐰)

@retep998
Copy link
Owner

The required minimal version will be increased in winapi 0.4.

@ArturKovacs
Copy link
Contributor Author

I'd like to add IContextMenu as well. Can I add commits that add new items or should I open another PR for things unrelated to the original content of the current PR?

@ArturKovacs ArturKovacs mentioned this pull request Nov 7, 2019
Open
@ArturKovacs
Copy link
Contributor Author

Every addition that this PR contains is also contained in #834 so I'll just close this.

@ArturKovacs ArturKovacs closed this Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting on review Waiting for a reviewer to review the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArturKovacs @retep998