Add a d3d11 wrapper #187
Merged
Add a d3d11 wrapper #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,15 +1,20 @@ | |||
| [package] | |||
| name = "d3d11-sys" | |||
| version = "0.0.1" | |||
| version = "0.1.0" | |||
There was a problem hiding this comment.
Don't change the crate version. I do that when I publish things to crates.io
|
Thanks! Reverted the version change and rebased onto master. Building should be successful. |
| // pub fn D3D11CreateDevice(); | ||
| // pub fn D3D11CreateDeviceAndSwapChain(); | ||
|
|
||
| pub fn D3D11CreateDevice(pAdapter: *const IDXGIAdapter, DriverType: D3D_DRIVER_TYPE, |
There was a problem hiding this comment.
Please use the multiline function style as dictated in CONTRIBUTING.md.
|
Also make sure all binary operators have spaces on both sides. I see a few cases where you're missing a space on the left of an |
| winapi = "*" | ||
| winapi = { version = "*", path = "../.." } | ||
| [build-dependencies] | ||
| winapi-build = { version = "*", path = "../../build" } |
msiglreith
force-pushed
the
pr_d3d11
branch
from
c47e3ff to
5a38095
Compare
|
Thanks for reviewing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bindings to d3d11 (including the Video API) and the structs/enums/constants.
I tested it with a small demo application with a msvc rust build. (MinGW needs additional libraries?)
NOTE: Requires changes to the interface macro
RIDL!and #164 for building.https://github.com/msiglreith/winapi-rs/blob/8210ef6df600abe9f77d65aa9c2b9e5697dbe383/src/d3d11.rs#L1263
pub constfor easier use?