This repository has been archived by the owner on Sep 21, 2021. It is now read-only.
Put the main thread handle in the thread context #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is it in all caps? |
|
Aren't globals supposed to be in all-caps ? |
|
Personally would rather reserve all caps for macros and enums and such. |
|
Also should I bump the libtransistor context version ? The change itself is backward compatible (old libtransistor binaries can use new context), but not forward compatible (new libtransistor binaires can't use old context). Meeh. |
|
Yes, the version should be incremented so the existence of the thread id field can be tested |
misson20000
approved these changes
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a scaled back version of #45 that simply adds the thread handle in the libtransistor context. Should be compatible with existing binaries.