Use random value for multipart/form-data boundary. #1464
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The request body might contain the previous, fixed value for FormBoundary.
This will cause a server to split the body on the wrong boundaries.
For example trying to post this file which already contains a boundary will generate an invalid request.
`-------------------------------28947758029299
Content-Disposition: form-data; name="somefile_REC.pdf"; filename="somefile_REC.pdf"
Content-Type: application/x-gzip
%PDF-1.4
[...] truncated
%%EOF
-------------------------------28947758029299--
`
By using a random value for the boundary collisions like this will be avoided.
Purpose
This pull request is a:
Checklist