Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-253] migrated from junit4 to junit5 #256

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

rsearls
Copy link
Contributor

@rsearls rsearls commented Mar 25, 2024

The junit4 dependencies remain in microprofile-rest-client-tck as I assume the tck is still using junit4.

@rsearls rsearls force-pushed the issue-253-junit5-migration branch from d536f49 to 67c73cc Compare March 28, 2024 16:58
@rsearls rsearls force-pushed the issue-253-junit5-migration branch from 67c73cc to e9cb27f Compare March 29, 2024 14:26
Copy link
Contributor

@jamezp jamezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one change that is required here, but I'll file a follow up PR for it. I think it's better to get this in now since the fix is fairly minor.

Comment on lines +80 to +84
try {
healthServiceClient.getHealthData();
} catch (WebApplicationException e) {
// this is the expected result
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be something like:

Assertions.assertThrows(WebApplicationException.class, () -> healthServiceClient.getHeathData());

@jamezp jamezp merged commit 5fadf81 into resteasy:main Apr 1, 2024
11 checks passed
@jamezp jamezp linked an issue Apr 1, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate project from junit4 to junit5
2 participants