Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ssl-vendored to Kafka #2292

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Add ssl-vendored to Kafka #2292

merged 3 commits into from
Nov 19, 2024
+26 −10

Conversation

slinkydeveloper
Copy link
Contributor

No description provided.

@jackkleeman
Copy link
Contributor

I think openssl is cargo deny banned

@jackkleeman
Copy link
Contributor

target/aarch64-apple-darwin/debug/restate-server: 318M with openssl, 313M without
target/aarch64-apple-darwin/release/restate-server: 93M with openssl, 89M without
target/aarch64-unknown-linux-gnu/release/restate-server: 108M with openssl, 105M without
target/aarch64-unknown-linux-musl/release/restate-server: 114M with openssl, 111M without

musl required a forked librdkafka (https://github.com/restatedev/librdkafka), to include this PR confluentinc/librdkafka#3535 which should be in the next release (but i understand we may not want to update librdkafka to latest, so the fork may be useful anyway)

@jackkleeman jackkleeman changed the title [WIP] Add ssl-vendored to Kafka Add ssl-vendored to Kafka Nov 18, 2024
tillrohrmann
tillrohrmann approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, it's compiling and tests are passing (not that we have terribly many Kafka tests). Did you test the Kafka integration with these changes @jackkleeman. Once this works, +1 for merging.

@jackkleeman
Copy link
Contributor

Yes I did @tillrohrmann

@jackkleeman jackkleeman merged commit 73fa9df into restatedev:main Nov 19, 2024
11 checks passed
jackkleeman added a commit to jackkleeman/restate that referenced this pull request Nov 19, 2024
@slinkydeveloper @jackkleeman
Add ssl-vendored to Kafka (restatedev#2292)
5772d91 
* Add ssl-vendored to Kafka

* Use forked librdkafka to support musl builds

* Don't deny openssl-sys

---------

Co-authored-by: Jack Kleeman <[email protected]>
jackkleeman added a commit to jackkleeman/restate that referenced this pull request Nov 19, 2024
@slinkydeveloper @jackkleeman
Add ssl-vendored to Kafka (restatedev#2292)
cfce392 
* Add ssl-vendored to Kafka

* Use forked librdkafka to support musl builds

* Don't deny openssl-sys

---------

Co-authored-by: Jack Kleeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

@jackkleeman jackkleeman Awaiting requested review from jackkleeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slinkydeveloper @jackkleeman @tillrohrmann