Document Promise combinators and determinism concerns #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
c732728
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e5e97dc5.documentation-beg.pages.dev |
| Branch Preview URL: | https://issue307.documentation-beg.pages.dev |
slinkydeveloper
requested changes
Mar 4, 2024
docs/services/sdk/side-effects.mdx
Outdated
Comment on lines
289
to
297
| Creates an Awaitable that awaits all of the provided Awaitables to resolve. | ||
|
|
||
| **Awaitable.any():** | ||
|
|
||
| ```shell | ||
| SomeResponse res = (SomeResponse) Awaitable.any(a1, a2, a3).await(); | ||
| ``` | ||
|
|
||
| Creates an Awaitable that awaits any of the provided Awaitables to resolve. |
There was a problem hiding this comment.
You can write down the the behaviour is similar to JDK's CompletableFuture.all/any
docs/services/sdk/side-effects.mdx
Outdated
| **Awaitable.all():** | ||
|
|
||
| ```shell | ||
| SomeResponse res = (SomeResponse) Awaitable.all(a1, a2, a3).await(); |
There was a problem hiding this comment.
This is wrong, SomeResponse returns Void.
There was a problem hiding this comment.
You need to then do Awaitable#await on the single awaitables (where the operation will be no-op because the value was awaited by await all)
There was a problem hiding this comment.
@slinkydeveloper Can you suggest what it should be? I am not sure what you mean
There was a problem hiding this comment.
Awaitable.all(a1, a2, a3).await();
SomeResponse a1Res = a1.await(); // This immediately returns valueSomething like that
slinkydeveloper
approved these changes
Mar 5, 2024
docs/services/sdk/side-effects.mdx
Outdated
|
|
||
| **CombineablePromise.allSettled():** | ||
|
|
||
| ```shell |
There was a problem hiding this comment.
Shouldn't this be typescript? same below with java?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #307
CombineablePromise.all/any/allSettled/racefor TSAwaitable.any/allfor Java