[bug fix] Run Error API actions #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses: #985 Addresses: #1071 ### Demo: https://user-images.githubusercontent.com/50227291/188673867-186d03e9-a8ec-4cb7-adb0-6a6483ba1cec.mov Since api resource is not saved due to any error, api action will keep track of user input with proper error message under `additional_data['api_resource']['properties']` and `additional_data['api_resource']['errors']` Demo shows error message and user input being accessed by api_action ### Demo fix dead set functionality https://user-images.githubusercontent.com/50227291/189976658-e7c6fbe8-1f69-4740-9e98-98835a8fae26.mov
|
failing UAT due to: #1324 (comment) |
Fix Demo: Screen.Recording.2023-01-03.at.9.26.40.PM.mov |
|
Deployed review-app can be viewed at https://review-1327.violet-test.net |
|
Deployed review-app can be viewed at https://review-1327.violet-test.net |
donrestarone
added a commit
that referenced
this pull request
Jan 4, 2023
Addresses: #985 Addresses: #1071 ### Demo: https://user-images.githubusercontent.com/50227291/188673867-186d03e9-a8ec-4cb7-adb0-6a6483ba1cec.mov https://user-images.githubusercontent.com/50227291/210391370-7d38a132-6d10-4cc4-85ed-d1eb14e088c8.mov Since api resource is not saved due to any error, api action will keep track of user input with proper error message under `additional_data['api_resource']['properties']` and `additional_data['api_resource']['errors']` Demo shows error message and user input being accessed by api_action ### Demo fix dead set functionality https://user-images.githubusercontent.com/50227291/189976658-e7c6fbe8-1f69-4740-9e98-98835a8fae26.mov ### Demo showing error message in API https://user-images.githubusercontent.com/50227291/196223270-e1d831f3-8403-43eb-84c2-d5419ea078d4.mov Co-authored-by: Pralish Kayastha <[email protected]> Co-authored-by: Pralish Kayastha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #985
Addresses: #1071
Demo:
Screen.Recording.2022-09-06.at.7.28.19.PM.mov
Screen.Recording.2023-01-03.at.9.26.40.PM.mov
Since api resource is not saved due to any error, api action will keep track of user input with proper error message under
additional_data['api_resource']['properties']andadditional_data['api_resource']['errors']Demo shows error message and user input being accessed by api_action
Demo fix dead set functionality
Screen.Recording.2022-09-13.at.11.40.18.PM.mov
Demo showing error message in API
Screen.Recording.2022-10-17.at.9.30.30.PM.mov