Improvements #35
Merged
Improvements #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jens1205
commented
Jul 21, 2021
•
jens1205
commented
- fix broken import files (reverted unnecessary use of raw_body from yesterdays PR)
- fix broken header extraction
- better / more reliable support for multiple requests in one file
- jump to the request line of the chosen request
- curl error messages
- fix broken import files - fix broken header extraction - better / more reliable support for multiple requests in one file - curl error messages
|
Hmm, I don't know selene, but for my understanding the code is correct. I have also tested it. Looks like your selene version does not support goto (Kampfkarren/selene#224) |
|
Hey, thank you so much, I'm really loving those changes! Also regarding to selene linter it seems that we should change the stdlib to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.