Include css and js from plugins if they are there (without updated gems)

[mattgibson]

This is a cleaner version of #85, but without the updated gems.

[coveralls]

Coverage increased (+0.28%) to 83.64% when pulling 890716d on mattgibson:plugin-assets into 10f2d2e on resque:master.

[coveralls]

Coverage increased (+0.28%) to 83.64% when pulling 890716d on mattgibson:plugin-assets into 10f2d2e on resque:master.

[coveralls]

Coverage increased (+0.28%) to 83.64% when pulling 890716d on mattgibson:plugin-assets into 10f2d2e on resque:master.

[mattgibson]

Hmm. Looks like it needs the gems updated for 2.2

[mcfiredrill]

@mattgibson Thank you for doing this. 💛

I see, perhaps you could make a PR to fix the Gems to pass on 2.2?
After that is merged, you (and other people with currently failing PRs) could rebase.

[mcfiredrill]

@mattgibson now that we merged your other PR for the Gems, could you rebase this PR?

[coveralls]

Coverage decreased (-0.13%) to 84.19% when pulling 41f6163 on mattgibson:plugin-assets into c09a9b4 on resque:master.

[mcfiredrill]

Not sure what the coveralls failure is about really, but this looks good.
Anyone else out there wanna 👍 this ?

[kirillplatonov]

@mattgibson Hi. Great job! 👏

Thinking about loading plugin's assets - not all plugins has its own assets. With stylesheet_link_tag and javascript_include_tag it will generate an error. Here's example with resque-scheduler plugin:

I think we need to think about this problem together. Could you give the link to the plugin, for which try to load assets, please?

[mattgibson]

@kirillplatonov Yes, this occurred to me too. I will see if I can add a file_exists check of some sort.

[kirillplatonov]

@mattgibson Probably Rails.application.assets.find_asset("application.css") will help?

[coveralls]

Coverage decreased (-0.42%) to 83.9% when pulling 984c059 on mattgibson:plugin-assets into c09a9b4 on resque:master.

[kirillplatonov]

Looks fine now 👍

[mattgibson]

Thanks. There's no tests for this, but I'm not sure of the best way of testing, or even if it's desirable. The plugins are in separate gems, so would it need a dummy gem of some sort?

[mcfiredrill]

@mattgibson @kirillplatonov
Thanks guys, seems good to merge now.

In the future, perhaps a test plugin (it doesn't have to actually do anything) could be added to the existing tests/test dummy app.