Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all controllers should be extending ResqueWeb::ApplicationController ins... #79

Merged
merged 1 commit into from
Mar 16, 2015

Conversation

jdatti
Copy link

@jdatti jdatti commented Feb 26, 2015

...tead of parent application's ::ApplicationController

…instead of parent application's ::ApplicationController
@jdatti
Copy link
Author

jdatti commented Feb 26, 2015

This pull request fixes
#76

@coveralls
Copy link

Coverage Status

Coverage increased (+0.99%) to 84.35% when pulling af66a10 on jdatti:master into 962b5b0 on resque:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.36% when pulling af66a10 on jdatti:master into 962b5b0 on resque:master.

@flynfish
Copy link

flynfish commented Mar 4, 2015

👍 would love to see this merged!

@mcfiredrill
Copy link

Hi I'm pretty sure this is the right thing to do, but I'm not really using Resque or ResqueWeb these days and don't really have time to test. Can anyone test this an confirm it fixes the issues like #76 and maybe others?

@mcfiredrill
Copy link

If a few people can confirm this is working, I will merge it.

mcfiredrill added a commit that referenced this pull request Mar 16, 2015
all controllers should be extending ResqueWeb::ApplicationController ins...
@mcfiredrill mcfiredrill merged commit e45e9c4 into resque:master Mar 16, 2015
@mcfiredrill
Copy link

This appears to solve a number of issues, I haven't tested it thoroughly as I'm not currently much of a resque user. However I want to help out if I can since I have commit access to this project.

I'm going to merge this and release a new Gem version soon. Cheers!

@rarruda
Copy link

rarruda commented Nov 10, 2015

It would be nice with a new release / new Gem version! I'm probably not the only one who could benefit from this bugfix! 😄

@rarruda rarruda mentioned this pull request Nov 10, 2015
@mcfiredrill
Copy link

@rarruda Oh sorry, I thought I did. I'll make a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants