New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addding heroku_will_terminate? #3

Merged

iloveitaly merged 4 commits into master from heroku-will-terminate

Jul 28, 2018

Collaborator

iloveitaly commented Jul 13, 2018

Added docs to explain the purpose
Used a global variable. I hate global variables, but storing this state in the worker seemed like a bad idea. A reference to the worker would need to be passed around to every object which wanted to see if the process would die.
A process dying soon feels like global state, so it didn't seem like a horrible idea to use a global variable

@pjambet would you mind taking a look here and offering some feedback?

iloveitaly added 4 commits

July 13, 2018 07:47


          Adding pry for debugging

e766722


          Adding heroku_will_terminate? to determine if a TERM signal has been …

33e05ec

…sent


          Test for heroku_will_terminate?

69c8749


          Docs for heroku_will_terminate

ef97d6c

Collaborator Author

iloveitaly commented Jul 28, 2018

@pjambet Merging this in, but feel free to submit a post-merge review.

iloveitaly merged commit 933ce82 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet