Make sure only valid entity names are used on initial form state #3100
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3100 +/- ##
===========================================
- Coverage 79.18% 78.96% -0.23%
===========================================
Files 165 166 +1
Lines 13267 13288 +21
Branches 1476 1530 +54
===========================================
- Hits 10506 10493 -13
- Misses 2467 2496 +29
- Partials 294 299 +5 ☔ View full report in Codecov by Sentry. |
cesarvarela
commented
Sep 16, 2024
| @@ -166,15 +166,17 @@ const SubmissionEdit = ({ id }) => { | |||
| developers: | |||
| submission.developers === null | |||
| ? [] | |||
| : submission.developers.map((item) => item.name || item), | |||
There was a problem hiding this comment.
The submission had a harmed_party with an empty name and was causing the Tags component to crash:
I'm not a fan of using entity names instead of ids, but this works for now.
cesarvarela
had a problem deploying
to
staging
GitHub Actions
Failure
kepae
approved these changes
Sep 16, 2024
kepae
merged commit 4725b95
into
responsible-ai-collaborative:staging
24 of 26 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://raicollab.slack.com/archives/C03L4FLEL2Y/p1726433890359339