Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all mongodb-awesome-backup repo code/actions to this repo #3030

Conversation

pdcp1
Copy link
Collaborator

@pdcp1 pdcp1 commented Aug 16, 2024

Part of issue #3023

This PR moves the whole GitHub Actions code from mongodb-awesome-backup to this repo.
It also fixes the broken CSET CSV file export.

The following GitHub Action is added.

  • .github/workflows/db-backup.yml

This action is responsible for generating the DB backup and DB snapshots.

New GitHub Actions environment secrets needed

These Cloudflare credentials must have write permissions

  • secrets.CLOUDFLARE_R2_WRITE_ACCESS_KEY_ID
  • secrets.CLOUDFLARE_R2_WRITE_SECRET_ACCESS_KEY

Testing

This code can be tested on Pablo's environment https://github.com/pdcp1/aiid/actions/workflows/db-backup.yml

Release considerations

Both GitHub Actions (Public backup to the cloud and Private backup to the cloud) on the original repo should be disabled as soon as we release this PR into Production.

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.34%. Comparing base (64e1275) to head (a889f57).
Report is 1 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #3030      +/-   ##
===========================================
+ Coverage    79.25%   79.34%   +0.09%     
===========================================
  Files          165      165              
  Lines        13263    13263              
  Branches      1524     1525       +1     
===========================================
+ Hits         10511    10523      +12     
+ Misses        2459     2447      -12     
  Partials       293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdcp1 pdcp1 requested a review from cesarvarela September 3, 2024 22:00
@pdcp1
Copy link
Collaborator Author

pdcp1 commented Sep 3, 2024

I'm taking my approval back because I'm noticing that we are not telling the workflow which environment it should get variables from (staging, production, etc.).

The environment input was added and it's ready for review

@smcgregor
Copy link
Collaborator

@pdcp1 Please ping me if/when I can retire the old repo.

@kepae
Copy link
Collaborator

kepae commented Sep 4, 2024

Secrets updated!
image

@cesarvarela cesarvarela merged commit 4046eb3 into responsible-ai-collaborative:staging Sep 5, 2024
25 of 26 checks passed
@pdcp1 pdcp1 deleted the feature/add-db-backup-gh-actions branch September 5, 2024 17:53
@pdcp1
Copy link
Collaborator Author

pdcp1 commented Sep 10, 2024

@pdcp1 Please ping me if/when I can retire the old repo.

@smcgregor According to our Slack conversation, @kepae will be in charge of this repo deactivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants