Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checklists ­– Test edit checklist title #2489

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Dec 12, 2023

Resolves #2454 and #2454.

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for staging-aiid failed.

Name Link
🔨 Latest commit d8b24dc
🔍 Latest deploy log https://app.netlify.com/sites/staging-aiid/deploys/65a02af3d1c4cd00083ff3b2

@lmcnulty
Copy link
Collaborator Author

lmcnulty commented Dec 14, 2023

Currently the test for updating the risk title fails – I think it's correct to do so. The GraphQL mutation does not seem to be triggered if you just edit the risk title and don't interact with the page otherwise – the change disappears if you immediately refresh the page. This is very strange because afaict, Formik's submitForm() is indeed being called. I was getting Missing field while writing result warning – will look into this more tomorrow.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.13%. Comparing base (feafdc0) to head (14c6349).

Files Patch % Lines
...by-site/src/components/checklists/EditableLabel.js 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2489      +/-   ##
===========================================
- Coverage    85.91%   77.13%   -8.79%     
===========================================
  Files          248      240       -8     
  Lines         8358     8099     -259     
  Branches      2635     2570      -65     
===========================================
- Hits          7181     6247     -934     
- Misses        1089     1671     +582     
- Partials        88      181      +93     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Jan 11, 2024

1 failed test on run #2407 ↗︎

1 482 248 0 Flakiness 0

Details:

Checklists ­– Test edit checklist title
Project: aiid-site Commit: 14c6349aba
Status: Failed Duration: 17:51 💡
Started: May 15, 2024 4:10 PM Ended: May 15, 2024 4:27 PM
Failed  cypress/e2e/integration/apps/checklistsForm.cy.js • 1 failed test • Cypress e2e tests

View Output

Test Artifacts
Checklists App Form > Should edit risk title Test Replay

Review all test suite changes for PR #2489 ↗︎

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant