Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated query and limit users to 9999 #2372

Merged
merged 9 commits into from
Nov 20, 2023
Merged

Remove duplicated query and limit users to 9999 #2372

merged 9 commits into from
Nov 20, 2023

Conversation

clari182
Copy link
Collaborator

@clari182 clari182 commented Oct 23, 2023 •
edited
Loading

On staging this can be tested on this incident: https://deploy-preview-2372--staging-aiid.netlify.app/incidents/edit/?incident_id=16 since it was failing for the same reason

@clari182 clari182 changed the base branch from master to staging October 23, 2023 20:25
@clari182 clari182 marked this pull request as draft October 23, 2023 20:25
@netlify
Copy link

netlify bot commented Oct 23, 2023 •
edited
Loading

✅ Deploy Preview for staging-aiid ready!

Name Link
🔨 Latest commit 8bfd7a5
🔍 Latest deploy log https://app.netlify.com/sites/staging-aiid/deploys/654ba5d4d7224c0008748ce4
😎 Deploy Preview https://deploy-preview-2372--staging-aiid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clari182 clari182 marked this pull request as ready for review October 25, 2023 11:55
@clari182 clari182 requested a review from cesarvarela October 25, 2023 11:55
@clari182 clari182 requested a review from cesarvarela November 1, 2023 16:42
cesarvarela
cesarvarela reviewed Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@cesarvarela cesarvarela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe unrelated but got an error when saving the edited incident:

image

@clari182
Copy link
Collaborator Author

clari182 commented Nov 2, 2023

@cesarvarela can you check if this is still happening? I couldn't reproduce it.

@clari182 clari182 requested a review from cesarvarela November 2, 2023 12:45
@cesarvarela
Copy link
Collaborator

@clari182 try adding another editor

@clari182
Copy link
Collaborator Author

clari182 commented Nov 6, 2023 •
edited
Loading

@cesarvarela ready for another review. Issue was related to user being unauthenticated

@clari182 clari182 requested a review from cesarvarela November 13, 2023 16:04
@clari182 clari182 mentioned this pull request Nov 20, 2023
Closed
@cesarvarela cesarvarela merged commit 035af83 into responsible-ai-collaborative:staging Nov 20, 2023
@clari182 clari182 deleted the fix/edit-incident-users branch November 21, 2023 16:09
pdcp1 pushed a commit to pdcp1/aiid that referenced this pull request Nov 21, 2023
@clari182 @pdcp1
Remove duplicated query and limit users to 9999 (responsible-ai-colla…
d6dfb3a 
…borative#2372)

* Remove duplicated query and limit users to 9999

* Trigger deploy

* Fix map of editors

* Fix admin test to use mock

* Add missing users to. mock

* Fix users list

* Fix user selection on userfields dropdown
@kepae kepae mentioned this pull request Nov 27, 2023
Merged
@kepae kepae mentioned this pull request Dec 26, 2023
Merged
@cesarvarela cesarvarela mentioned this pull request Dec 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesarvarela cesarvarela Awaiting requested review from cesarvarela

Assignees

@cesarvarela cesarvarela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Incident – Blank page error
2 participants
@clari182 @cesarvarela