-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/prismic docs #2287
Merged
cesarvarela
merged 13 commits into
responsible-ai-collaborative:staging
from
clari182:feature/prismic-docs
Nov 16, 2023
Merged
Feature/prismic docs #2287
cesarvarela
merged 13 commits into
responsible-ai-collaborative:staging
from
clari182:feature/prismic-docs
Nov 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for staging-aiid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pdcp1
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. The only thing that I think is missing is the test of this new feature.
pdcp1
approved these changes
Oct 23, 2023
cesarvarela
approved these changes
Oct 27, 2023
@cesarvarela can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows docs to be created via Prismic.
Docs are essentially pages, like about, contact & follow etc
This fetches docs from prismic and available doc mdx files present. It will only create MDX pages with available slugs.
For example if the contact page is in Prismic with slug
/contact
and an MDX file exists with slug/contact
it will only use the prismic one.