Fallback to sponsors JSON if no sponsors in prismic #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
clari182
commented
Aug 1, 2023
•
clari182
commented
- Preview with sponsor content coming from Prismic: https://deploy-preview-2211--staging-aiid.netlify.app/
- Preview with fallback content (local json): https://deploy-preview-25--clarayoudale-staging.netlify.app/
✅ Deploy Preview for staging-aiid ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Maybe we adopt this approach across the board for Prismic content? The source code can have a bunch of filler contents as a default unless Prismic contents are defined. If we do this, we would not have the AIID-specific contents in the defaults, but instead have blank contents. |
cesarvarela
reviewed
Sep 25, 2023
|
Hey @cesarvarela can you review this PR please? Thanks! |
cesarvarela
approved these changes
Oct 27, 2023
|
@cesarvarela can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.