Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on 3 branches #148

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Run tests on 3 branches #148

merged 1 commit into from
Apr 2, 2024

Conversation

rburghol
Copy link
Contributor

@rburghol rburghol commented Apr 1, 2024

if I were to accept this PR as is, what would be the effect of these failed tests? Maybe they should be left out of the PR until we get those details resolved?

  • The failed tests don't do anything, unless we require all tests to pass in order to do a merge (but I am pretty sure the system doesn't prevent it).
  • My thinking (maybe flawed) is that the only way to test if the dev install test is correct is to have a runnable test, and to try, hence why I included them.
  • We can, however disable these tests once they are merged into the develop branch, and thus are in the system. To disable, go to "Actions" -> "Pyton conda dev application" and click on "Disable workflow" (see image below)
    • BUT, since now we already know the current test doesn't function, we can omit it, however, I was struggling to figure out a way to insure that the code was there in case someone else wanted to give it a whirl and didn't want to start from scratch, or at least wanted my example of what not to do.

image

@rburghol rburghol mentioned this pull request Apr 1, 2024
@PaulDudaRESPEC PaulDudaRESPEC merged commit 34a56c8 into respec:develop Apr 2, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants