Devstate #118
Closed
Devstate #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing initial state variable table, and fill with default values. Addresses Issue #96 where the IWAT-STATE1 table did not exist in the UCI.
…minates warning message about inefficiency
…or use in advection, correcting a potential problem with initial non-zero outflows
specl functions defined and initial testing successful
Constrained JupyterLab version and removed optional plugins, due to JupyterLab updates starting causing errors. Clarified installation instructions to better separate the two installation options, which are mutually exclusive.
The time series for inorganic species of nutrients was being assigned an incorrect key in the timeseries dictionary returned by the utlities.get_stimeseries function. The timeseries were not coded with an underscore between the TMEMN and TMEMSB definition as expected by the RQUAL module (https://github.com/respec/HSPsquared/blob/f9555f2e48cc3409f33c29d3c6504d9bdc0f91fb/HSP2/RQUAL_Class.py#L439-L449).
This Python 3.9 environment is basically the same I used for demos and testing in Jan. 2022.
incorrect timeseries key assignment for inorganic nutrient species
test passing the TS and modifying the last step value
Adding a bit more documentation and additional examples for the interactive HoloViz plotting libraries that we use.
Initial SPECL.py PR
Adjust Columns to Parse HYDRO-INIT block
Fix pip install bug when jupyter lab version restricted to 3.0.*
5 tasks
added 2 commits
June 29, 2023 15:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to merge the prototype state functions and dynamic python timestep mods into develop.
See issue for functional details and demonstration of capabilities #113