This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
fix: long-press closes popups and light sliders immediately #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the fix from here: https://gist.github.com/jtangelder/361052976f044200ea17 as suggested by hammer.js here: https://hammerjs.github.io/tips/
|
Just cleaned up a little and rebased to master (as otherwise, popup was failing to open). I'm fine with this one. :) |
rchl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #405
closes #407
Thought, I'd share this. It has been running here for quite some time and fixes some annoying issues. I know, it is not as full-blown as #407. But it works. And #407 hasn't seen much progress lately. The down-side of this fix is, that we really cannot click in the region of a long-press for some fixed timeout.
using the fix from here: https://gist.github.com/jtangelder/361052976f044200ea17
as suggested by hammer.js here: https://hammerjs.github.io/tips/