Skip to content
This repository has been archived by the owner on Nov 4, 2023. It is now read-only.

Suggestion: Offline MDI #453

Closed
akloeckner opened this issue Oct 4, 2020 · 6 comments · Fixed by #468
Closed

Suggestion: Offline MDI #453

akloeckner opened this issue Oct 4, 2020 · 6 comments · Fixed by #468
Labels
enhancement New feature or request

Comments

@akloeckner
Copy link
Contributor

MD icons are currently loaded from the web. This might cause some issues, like #426 I believe. Also, this is the only resource not bundled with Tileboard. I suggest to include the icons in the bundle, if possible.

It seems, this might be a suitable approach: https://google.github.io/material-design-icons/#icon-font-for-the-web (second method)

@resoai
Copy link
Collaborator

resoai commented Oct 4, 2020

I agree. Having icons in a font file is an adequate solution.

@rchl
Copy link
Collaborator

rchl commented Oct 4, 2020

We are using https://materialdesignicons.com/ and not the official google funt but it's should be as easy. Just need to npm install @mdi/font and maybe update rollup config to handle font files.

@akloeckner
Copy link
Contributor Author

akloeckner commented Oct 4, 2020

maybe update rollup config

:-) OK... I'll have to leave that to you then.

BTW: I just found another CSS import in themes.less from the web, some cyrillic font apparently.

@import (css) url(https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&subset=cyrillic);

@rchl
Copy link
Collaborator

rchl commented Oct 5, 2020

Yes, that's a font (not an icon font) used by one of the themes. I suppose @resoai wanted a font that can display his language. :) Is it still relevant for you @resoai ?

@resoai
Copy link
Collaborator

resoai commented Oct 5, 2020

@rchl Roboto is a nice font in general and being Russian I decided to include Cyrillic subset of letters, so in a way, yeah, this is still relevant :)

@rchl rchl added the enhancement New feature or request label Oct 6, 2020
@rchl rchl closed this as completed in #468 Oct 12, 2020
rchl added a commit that referenced this issue Oct 12, 2020
)

Also enabling minimize CSS in production.

Resolves #453
@rchl
Copy link
Collaborator

rchl commented Oct 12, 2020

This required a fix in rollup plugin but thankfully the author was responsive and it was integrated and released quickly. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants