fix: programmatic openPopup can end up with dead tiles (#843)

resoai · Jun 30, 2022 · 1a11c5a · 1a11c5a
1 parent c6dd7d4
commit 1a11c5a
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/scripts/controllers/main-utilities.js b/scripts/controllers/main-utilities.js
@@ -68,11 +68,11 @@ export function mergeTileDefaults (tile) {
             mergeTileListDefaults(mergedTile.layout.tiles);
          }
          break;
-      case TYPES.POPUP:
-         if (mergedTile.popup?.items) {
-            mergeTileListDefaults(mergedTile.popup.items);
-         }
-         break;
+   }
+   // "popup" property is only officially supported in POPUP types but in the wild it can be added to any
+   // tile and then passed programmatically when calling "openPopup".
+   if (mergedTile.popup?.items) {
+      mergeTileListDefaults(mergedTile.popup.items);
    }
    mergedTile[MERGED_DEFAULTS_KEY] = true;
    return mergedTile;