Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GST Invoice Management System (IMS) Implementation #2638

Draft
wants to merge 178 commits into
base: develop
Choose a base branch
from

Conversation

Ninad1306
Copy link
Contributor

@Ninad1306 Ninad1306 commented Sep 23, 2024

@Ninad1306 Ninad1306 requested a review from vorasmit September 23, 2024 12:12
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 31.73077% with 426 lines in your changes missing coverage. Please review.

Project coverage is 57.39%. Comparing base (4a20e41) to head (bc2ee4f).
Report is 9 commits behind head on develop.

Files with missing lines Patch % Lines
...management_system/gst_invoice_management_system.py 0.00% 172 Missing ⚠️
.../doctype/gst_invoice_management_system/__init__.py 30.68% 61 Missing ⚠️
...conciliation_tool/purchase_reconciliation_utils.py 12.50% 49 Missing ⚠️
...mpliance/gst_india/api_classes/taxpayer_returns.py 53.22% 29 Missing ⚠️
...ndia_compliance/gst_india/utils/gstr_2/__init__.py 44.00% 28 Missing ⚠️
india_compliance/gst_india/utils/gstr_2/ims.py 74.31% 28 Missing ⚠️
...iance/gst_india/doctype/gstr_action/gstr_action.py 25.00% 12 Missing ⚠️
...st_india/doctype/gst_return_log/generate_gstr_1.py 26.66% 11 Missing ⚠️
...econciliation_tool/purchase_reconciliation_tool.py 28.57% 10 Missing ⚠️
india_compliance/gst_india/utils/gstr_utils.py 28.57% 10 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2638      +/-   ##
===========================================
- Coverage    58.40%   57.39%   -1.02%     
===========================================
  Files          122      126       +4     
  Lines        12162    12676     +514     
===========================================
+ Hits          7103     7275     +172     
- Misses        5059     5401     +342     
Files with missing lines Coverage Δ
..._compliance/gst_india/api_classes/taxpayer_base.py 24.57% <100.00%> (ø)
india_compliance/gst_india/constants/__init__.py 100.00% <100.00%> (ø)
india_compliance/gst_india/utils/gstr_2/gstr.py 89.55% <100.00%> (ø)
...dia/doctype/gst_inward_supply/gst_inward_supply.py 76.47% <60.00%> (-1.31%) ⬇️
india_compliance/gst_india/utils/__init__.py 76.29% <28.57%> (-0.77%) ⬇️
...gst_india/doctype/gst_return_log/gst_return_log.py 24.27% <18.18%> (-0.88%) ⬇️
...econciliation_tool/purchase_reconciliation_tool.py 25.73% <28.57%> (+2.79%) ⬆️
india_compliance/gst_india/utils/gstr_utils.py 38.33% <28.57%> (-2.49%) ⬇️
...st_india/doctype/gst_return_log/generate_gstr_1.py 14.40% <26.66%> (-0.11%) ⬇️
...iance/gst_india/doctype/gstr_action/gstr_action.py 36.84% <25.00%> (-63.16%) ⬇️
... and 6 more

... and 2 files with indirect coverage changes

Impacted file tree graph

@Ninad1306 Ninad1306 force-pushed the ims_api_implementation branch from 3fbd359 to 322cc4b Compare September 24, 2024 06:30
@Ninad1306 Ninad1306 force-pushed the ims_api_implementation branch from 322cc4b to 3d72bf1 Compare September 24, 2024 06:32
@vorasmit vorasmit marked this pull request as draft September 24, 2024 10:34
@Ninad1306 Ninad1306 assigned Ninad1306 and unassigned vorasmit Oct 15, 2024
@Ninad1306 Ninad1306 removed the request for review from vorasmit October 15, 2024 11:14
@Ninad1306 Ninad1306 changed the title fix: IMS Api Implementation fix: IMS Implementation Oct 25, 2024
@Ninad1306
Copy link
Contributor Author

IMS Docs: resilient-tech/india-compliance-docs#52

@Ninad1306 Ninad1306 force-pushed the ims_api_implementation branch from 22d5ab1 to c6cb0e9 Compare January 17, 2025 06:25
@vorasmit vorasmit changed the title fix: IMS Implementation feat: GST Invoice Management System (IMS) Implementation Jan 21, 2025
return query.where(self.IMS.ims_action != self.IMS.previous_ims_action).run(
as_dict=True

def get_for_reset(self, company_gstin):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants