Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle If response_json Is None #1968

Merged
merged 3 commits into from
Apr 6, 2024
Merged

fix: Handle If response_json Is None #1968

merged 3 commits into from
Apr 6, 2024

Conversation

Abdeali099
Copy link
Member

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 62.24%. Comparing base (a0f9b2d) to head (c3d1326).
Report is 4 commits behind head on develop.

Files Patch % Lines
india_compliance/gst_india/api_classes/base.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1968      +/-   ##
===========================================
+ Coverage    62.22%   62.24%   +0.02%     
===========================================
  Files          104      104              
  Lines         8672     8677       +5     
===========================================
+ Hits          5396     5401       +5     
  Misses        3276     3276              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sanket322 Sanket322 requested a review from vorasmit April 4, 2024 10:30
@sagarvora sagarvora merged commit efbcb67 into develop Apr 6, 2024
14 checks passed
@sagarvora sagarvora deleted the fix-copy-response branch April 6, 2024 05:36
mergify bot pushed a commit that referenced this pull request Apr 6, 2024
* fix: handle if `response_json` is `None`

* fix: optimise `mask_sensitive_info`

* test: fix  in make_sensitive_info

---------

Co-authored-by: Sagar Vora <[email protected]>
(cherry picked from commit efbcb67)
mergify bot pushed a commit that referenced this pull request Apr 6, 2024
* fix: handle if `response_json` is `None`

* fix: optimise `mask_sensitive_info`

* test: fix  in make_sensitive_info

---------

Co-authored-by: Sagar Vora <[email protected]>
(cherry picked from commit efbcb67)
mergify bot added a commit that referenced this pull request Apr 6, 2024
…tfix/pr-1968

fix: Handle If `response_json` Is `None` (backport #1968)
mergify bot added a commit that referenced this pull request Apr 6, 2024
…tfix/pr-1968

fix: Handle If `response_json` Is `None` (backport #1968)
india-compliance-bot added a commit that referenced this pull request Apr 10, 2024
## [14.26.3](v14.26.2...v14.26.3) (2024-04-10)

### Bug Fixes

* add overlaping invoice count summary to overview ([153a57f](153a57f))
* B2C(Others) and B2C(Large) category and subcategory assignment ([#1957](#1957)) ([dccbb2e](dccbb2e))
* group overview in GST sales register beta by category ([#2002](#2002)) ([fa0a8d4](fa0a8d4))
* group tax values and amounts for invoice print formats ([a9043a4](a9043a4))
* Handle If `response_json` Is `None` ([#1968](#1968)) ([c28a40d](c28a40d))
* **minor:** allow 673 like pin code for puducherry ([54c6e45](54c6e45))
* **minor:** correct function call for js ([7600d8a](7600d8a))
* missing gst amounts in hsn json ([5a76c92](5a76c92))
* overlap count for nil-rated , non-gst and exempted invoices ([03fa127](03fa127))
* ReferenceError: taxes_table is not defined in Journal Entry ([f5b1b86](f5b1b86))
* rounding of other charges for e-Invoice ([#1980](#1980)) ([7728426](7728426))
* **ux:** better error message ([b6287f1](b6287f1))
india-compliance-bot added a commit that referenced this pull request Apr 11, 2024
## [15.7.2](v15.7.1...v15.7.2) (2024-04-11)

### Bug Fixes

* add overlaping invoice count summary to overview ([42bb359](42bb359))
* B2C(Others) and B2C(Large) category and subcategory assignment ([#1957](#1957)) ([469f3c9](469f3c9))
* group overview in GST sales register beta by category ([#2002](#2002)) ([d00fc4a](d00fc4a))
* group tax values and amounts for invoice print formats ([fd18236](fd18236))
* Handle If `response_json` Is `None` ([#1968](#1968)) ([43cae15](43cae15))
* **minor:** allow 673 like pin code for puducherry ([741b7a9](741b7a9))
* **minor:** better way to override totals in gst sales beta report ([#2022](#2022)) ([cdf08a0](cdf08a0))
* **minor:** correct function call for js ([a8ec056](a8ec056))
* missing gst amounts in hsn json ([d558ff6](d558ff6))
* overlap count for nil-rated , non-gst and exempted invoices ([120ebb0](120ebb0))
* ReferenceError: taxes_table is not defined in Journal Entry ([f3ef20a](f3ef20a))
* rounding of other charges for e-Invoice ([#1980](#1980)) ([78838a7](78838a7))
* uom as per gst ([#2019](#2019)) ([8cdf609](8cdf609))
* **ux:** better error message ([1262798](1262798))
* validate for cess non-advol ([#2009](#2009)) ([d3d6997](d3d6997))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants