Merge pull request #1943 from priyanshshah2442/fix_taxable_value

fix: update `taxable value` on updating items after submitting Sales Order and Purchase Order
resilient-tech · Mar 29, 2024 · 1f265e3 · 1f265e3
2 parents 37cea7f + 118a40f
commit 1f265e3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/india_compliance/gst_india/overrides/transaction.py b/india_compliance/gst_india/overrides/transaction.py
@@ -1398,3 +1398,25 @@ def after_mapping(target_doc, method=None, source_doc=None):
 def ignore_gst_validations(doc):
     if not is_indian_registered_company(doc) or doc.get("is_opening") == "Yes":
         return True
+
+
+def before_update_after_submit_item(doc, method=None):
+    frappe.flags.through_update_item = True
+
+
+def before_update_after_submit(doc, method=None):
+    if not frappe.flags.through_update_item:
+        return
+
+    if ignore_gst_validations(doc):
+        return
+
+    validate_items(doc)
+
+    if is_sales_transaction := doc.doctype in SALES_DOCTYPES:
+        validate_hsn_codes(doc)
+
+    valid_accounts = validate_gst_accounts(doc, is_sales_transaction) or ()
+    update_taxable_values(doc, valid_accounts)
+    validate_item_wise_tax_detail(doc, valid_accounts)
+    update_gst_details(doc)
diff --git a/india_compliance/hooks.py b/india_compliance/hooks.py
@@ -151,6 +151,10 @@
         ),
         "before_save": "india_compliance.gst_india.overrides.transaction.update_gst_details",
         "before_submit": "india_compliance.gst_india.overrides.transaction.update_gst_details",
+        "before_update_after_submit": "india_compliance.gst_india.overrides.transaction.before_update_after_submit",
+    },
+    "Purchase Order Item": {
+        "before_update_after_submit": "india_compliance.gst_india.overrides.transaction.before_update_after_submit_item",
     },
     "Purchase Receipt": {
         "onload": [
@@ -193,6 +197,10 @@
         ),
         "before_save": "india_compliance.gst_india.overrides.transaction.update_gst_details",
         "before_submit": "india_compliance.gst_india.overrides.transaction.update_gst_details",
+        "before_update_after_submit": "india_compliance.gst_india.overrides.transaction.before_update_after_submit",
+    },
+    "Sales Order Item": {
+        "before_update_after_submit": "india_compliance.gst_india.overrides.transaction.before_update_after_submit_item",
     },
     "Supplier": {
         "validate": [