Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MidasRWA: mBTC plugin #1236

Open
wants to merge 6 commits into
base: 4.0.0
Choose a base branch
from
Open

MidasRWA: mBTC plugin #1236

wants to merge 6 commits into from

Conversation

julianmrodri
Copy link
Contributor

No description provided.

@julianmrodri julianmrodri changed the title Midas plugin MidasRWA: mBTC plugin Jan 29, 2025
@julianmrodri
Copy link
Contributor Author

julianmrodri commented Jan 30, 2025

@dmytro-horbatenko some comments regarding the PR:

  • I suggest having different contracts for the mBTC one (NonFiat) and for the one that is pegged to USD (Fiat) instead of having logic regarding target name in the plugin.

  • Tests should be in the common format as all other 99% plugin tests using the generic suite collateralTests.ts , and adding specific tests if required. The tests in the PR need to be refactored to that format.

  • There are some tests failing as well.

Fixing this is not a guarantee we will proceed with the plugin as there are other requirements to be considered in terms of liquidity, oracles, fees, restrictions which all seem to apply to Midas and would require further analysis.

In any case we still appreciate the contribution and interest in being part of the Reserve ecosystem. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants