Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Registry Setup & Basket Normalization Spell #1219

Merged
merged 14 commits into from
Oct 29, 2024
Merged

Add Registry Setup & Basket Normalization Spell #1219

merged 14 commits into from
Oct 29, 2024

Conversation

akshatmittal
Copy link
Member

No description provided.

@akshatmittal akshatmittal changed the title Add Registry Setup Add Registry Setup & Basket Normalization Spell Oct 23, 2024
@akshatmittal akshatmittal marked this pull request as ready for review October 23, 2024 22:21
@akshatmittal akshatmittal requested a review from tbrent October 23, 2024 22:21
tbrent
tbrent approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@tbrent tbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice catches around the edges in quite a few places 👍

I'm not sure I understand the removal of the TestIDeployer interface so maybe share some of the context there, but I'm good to move forward

@akshatmittal akshatmittal merged commit f9380fd into 4.0.0 Oct 29, 2024
15 checks passed
@akshatmittal akshatmittal deleted the registry-deployer branch October 29, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrent tbrent tbrent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshatmittal @tbrent