Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit rounding direction #1167

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add explicit rounding direction #1167

merged 2 commits into from
Jul 5, 2024

Conversation

julianmrodri
Copy link
Contributor

  • Add explicit rounding directions in a few contracts
  • Fix rounding direction in ReadFacade

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jul 5, 2024 •
edited
Loading

Add explicit rounding direction

Generated at commit: 72856a7c4f852351a7d6433109e668ff720cbe54

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 3
3
0
15
37
58
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tbrent tbrent merged commit 297d06e into 4.0.0 Jul 5, 2024
14 checks passed
@tbrent tbrent deleted the qa-rounding branch July 5, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbrent tbrent tbrent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianmrodri @tbrent