Meta morpho scripts #1098
Merged
Meta morpho scripts #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatmittal
requested changes
Mar 22, 2024
| chainlinkFeed: USDT_USD_FEED, | ||
| oracleError: USDT_ORACLE_ERROR.toString(), | ||
| erc20: networkConfig[chainId].tokens.bbUSDT, | ||
| maxTradeVolume: fp('1e6').toString(), // $7.5m vault |
There was a problem hiding this comment.
I think we should be using much smaller numbers for this. The vaults are currently too small to sustain these.
There was a problem hiding this comment.
Ok I think $500k can make sense, but much lower and things become unusable on mainnet
There was a problem hiding this comment.
And <$500k for pyUSD, since it has $1.7m vault
There was a problem hiding this comment.
That sounds good to me. Probably $250k for smaller vaults and $500k for every other.
akshatmittal
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.