-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-email): Add Windows support for build process #1699
fix(react-email): Add Windows support for build process #1699
Conversation
|
@chuanxshi is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
Hey, thank you so much for this PR! A lot of details always get past testing and are only seen when trying to contribute or running a specific edge-case, so I appreciate the help! Added a few minor comments for us to improve this together |
749774d
to
51b800d
Compare
@gabrielmfern I’ve made the updates based on the feedback. Please take a look when you have a moment. Thank you! |
0c0e618
to
fbbab7e
Compare
f69b971
to
86fe0ef
Compare
0b21151
to
30a20d6
Compare
fbbab7e
to
8ca96c3
Compare
Description
This PR addresses compatibility issues with the build process on Windows systems by adding support for Windows-specific executables. Previously, the build script utilized the Unix-like
next
executable, which isn't compatible with Windows environments. This fix ensures that the correct executable (next.cmd
) is used based on the operating system.Changes
build-preview-server.mjs
to detect the operating system.next.cmd
for Windows andnext
for Unix-like systems.Motivation and Context
Developers using Windows encountered errors when attempting to run the build process due to the incorrect executable being invoked. This fix ensures a seamless build experience across all major operating systems.
How Has This Been Tested?
dist/preview/.next
directory is correctly populated.Types of Changes
Checklist: