Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete dead old records with ridiculous IDs #594

Merged
merged 1 commit into from
Apr 16, 2023

Conversation

matuskalas
Copy link
Contributor

@matuskalas matuskalas commented Mar 28, 2023

Scope: Records that have consolidated PIDs in Bio.tools now

7e140cf was supposed to be here, too.

These were the 2 records I found because they couldn't be checked-out on Win.

There likely are more records in TE which aren't in Bio.tools anymore.

Suggested further work (#595):

  • Validation of IDs as part of CI in TE
  • Bio.tools, OEB, BIII, etc. PRs deleting old records! Work needed in those resources to keep track of deletions!
  • TE CI should purge empty directories
  • I would also love if TE CI maintains a log / TSV / dashboard that would show deleted records (maybe also added and updated)

@matuskalas matuskalas marked this pull request as draft March 28, 2023 13:30
@matuskalas matuskalas marked this pull request as ready for review March 28, 2023 14:55
@matuskalas matuskalas added bug Something isn't working content labels Mar 28, 2023
@matuskalas
Copy link
Contributor Author

Not a bug, but there is no "missing feature" label 😊

@hmenager hmenager merged commit 9487ed4 into master Apr 16, 2023
@hmenager hmenager deleted the delete-dead-old-records-with-ridiculous-IDs branch June 12, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants