Hot fix for 4.2.3 breaks semver patch #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh god! that's true haha good catch, thanks |
fakenickels
approved these changes
Feb 22, 2018
|
@grsabreu I think there are more 😢 . We have Helpers inside Helpers module |
|
oh jeez 🤔 weird that I thought I had flatten that |
|
do you wanna send a PR fixing this too? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From 4.2.2 to 4.2.3, you have moved modules into individual files which breaks semver and causing namespace conflicting because
Helpersis such a common module name. This PR made the public API compatible with 4.2.2 and also solve the namespace conflicting issue.