Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move list identifier constructor list{ to scanner #189

Closed
aspeddro opened this issue Dec 4, 2022 · 0 comments · Fixed by #190
Closed

Move list identifier constructor list{ to scanner #189

aspeddro opened this issue Dec 4, 2022 · 0 comments · Fixed by #190

Comments

@aspeddro
Copy link
Collaborator

aspeddro commented Dec 4, 2022 •
edited
Loading

I think we can simplify this part of the query if we check list{ in the scanner.

https://github.com/nkrkv/tree-sitter-rescript/blob/f2be69c639346cad0126c64ca256aa931467e008/queries/highlights.scm#L16-L21

Some editors don't support priority property, see helix-editor/helix#4356 (comment)
aspeddro added a commit to aspeddro/tree-sitter-rescript that referenced this issue Dec 4, 2022
@aspeddro
refactor: move list identifier to scanner
a18eda7 
Close rescript-lang#189
@aspeddro aspeddro mentioned this issue Dec 4, 2022
Merged
@nkrkv nkrkv closed this as completed in #190 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move list identifier to scanner aspeddro/tree-sitter-rescript
1 participant
@aspeddro