Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncurried Mode docs #748

Merged

Conversation

fhammerschmidt
Copy link
Member

No description provided.

Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
CC @zth for additional comments.

Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we can extend it when people ask questions. I guess we don't want to document @@uncurried.swap?

@cristianoc
Copy link
Contributor

Looks good to me, we can extend it when people ask questions. I guess we don't want to document @@uncurried.swap?

Not really, as there are no plans to support that feature longer term. It was just for internal debugging.

@fhammerschmidt fhammerschmidt merged commit 233bf6b into rescript-lang:rescript-11 Nov 14, 2023
1 check passed
@fhammerschmidt fhammerschmidt deleted the uncurried-mode-docs branch November 14, 2023 14:23
@ryyppy
Copy link
Member

ryyppy commented Nov 14, 2023

Bit late, but this doc feels weird, since the whole docs should revolve around uncurried to be the default and not document it as if it would be something special.

The blog post regarding curried vs uncurried should have been enough, or at most we could have made a guide for migrating from curried to the new uncurried behavior.

The partial application syntax should IMO have been part of "Function" instead

@fhammerschmidt
Copy link
Member Author

You are right, I will split it up over Function and build system docs.
The @@uncurried decorator can probably just be added to the syntax lookup.

A migration guide (uncurried, core, rescript.json) is in the works, btw. But I am migrating a codebase while writing it, so it will take a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants