Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Int.range and Int.rangeWithOptions #52

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

glennsl
Copy link
Contributor

@glennsl glennsl commented Feb 18, 2023

Submitted for consideration.

Depends on #49 for Array.init. It could also be implemented, more efficiently, by internally binding to a few unsafe array primitives.

This should be compatible with the TC39 stage 1 proposal for Number.range, except it returns an array instead of an iterator.

TODO:

  • Documentation
  • Tests

@glennsl glennsl marked this pull request as draft February 18, 2023 16:04
@glennsl glennsl marked this pull request as ready for review March 5, 2023 16:17
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! @cknitt ?

src/Core__Int.resi Outdated Show resolved Hide resolved
Co-authored-by: Gabriel Nordeborn <[email protected]>
src/Core__Int.resi Outdated Show resolved Hide resolved
src/Core__Int.resi Outdated Show resolved Hide resolved
Co-authored-by: Christoph Knittel <[email protected]>
@zth zth merged commit dc85ee6 into rescript-lang:main Mar 6, 2023
@glennsl glennsl deleted the feat/int/range branch March 6, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants